eventReducer: critical type bug fixed: zero must be string

AmbireTech · Dec 8, 2019 · cea6df4 · cea6df4
1 parent 32fa597
commit cea6df4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/services/sentry/lib/eventReducer.js b/services/sentry/lib/eventReducer.js
@@ -36,8 +36,8 @@ function mergeEv(initialMap = { eventCounts: {}, eventPayouts: {} }, ev, payout)
 	}
 	if (typeof ev.publisher !== 'string') return map
 	const earner = toBalancesKey(ev.publisher)
-	if (!map.eventCounts[earner]) map.eventCounts[earner] = new BN(0)
-	if (!map.eventPayouts[earner]) map.eventPayouts[earner] = new BN(0)
+	if (!map.eventCounts[earner]) map.eventCounts[earner] = '0'
+	if (!map.eventPayouts[earner]) map.eventPayouts[earner] = '0'
 
 	// increase the event count
 	const newEventCounts = new BN(map.eventCounts[earner], 10)

diff --git a/test/integration.js b/test/integration.js
@@ -438,8 +438,8 @@ tape('should record clicks', async function(t) {
 
 	await postEvsAsCreator(leaderUrl, channel.id, evs)
 	// Technically we don't need to tick, since the events should be reflected immediately
-	const analytics = await fetch(`${leaderUrl}/analytics/${channel.id}?eventType=CLICK`).then(res =>
-		res.json()
+	const analytics = await fetch(`${leaderUrl}/analytics/${channel.id}?eventType=CLICK`).then(r =>
+		r.json()
 	)
 	t.equal(analytics.aggr[0].value, num.toString(), 'proper number of CLICK events')