Move timeout to read task #18623
Open
Move timeout to read task #18623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haoning-Sun
force-pushed
the
fix/read-endless-loop
branch
from
1c8802f
to
a6e33cb
Compare
Haoning-Sun
force-pushed
the
fix/read-endless-loop
branch
from
a6e33cb
to
76709a1
Compare
ccy00808
reviewed
Jul 4, 2024
| @@ -339,8 +337,6 @@ public CompletableFuture<List<BlockStatus>> load(List<Block> blocks, UfsReadOpti | |||
| () -> manager.read(buf, block.getOffsetInFile(), blockSize, blockId, | |||
| block.getUfsPath(), options), | |||
| new ExponentialBackoffRetry(1000, 5000, 5)) | |||
| // use orTimeout in java 11 | |||
| .applyToEither(timeoutAfter(LOAD_TIMEOUT, TimeUnit.MILLISECONDS), d -> d) | |||
There was a problem hiding this comment.
mDelayer and LOAD_TIMEOUT are not used and deleted?
Haoning-Sun
force-pushed
the
fix/read-endless-loop
branch
from
8578380
to
7ec4cc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Move timeout to read task. Make the task cancel when it times out.
Why are the changes needed?
Currently, the buffer will be released when the task times out, but the task is not cancelled. The buffer may continue to be used. The buffer is used by multiple tasks, which may cause some exceptions.