Revert to pre-2023.3.15 tifffile to avoid mm_stack issue #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 93.98% 93.98%
=======================================
Files 53 53
Lines 4658 4658
=======================================
Hits 4378 4378
Misses 280 280
☔ View full report in Codecov by Sentry. |
evamaxfield
approved these changes
Sep 19, 2023
toloudis
reviewed
Sep 19, 2023
| "xarray>=0.16.1,<2023.02.0", | ||
| "xmlschema", # no pin because it's pulled in from OME types | ||
| "zarr>=2.6,<3", | ||
| "zarr>=2.6,<2.16.0", |
There was a problem hiding this comment.
just curious, do you happen to know why we have to do the zarr constraint?
There was a problem hiding this comment.
The _get_image_data() relies on reading the image data as zarr per the argument aszarr
toloudis
approved these changes
Sep 19, 2023
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to resolve issue installing
aicsimageiowith conflictingbfiodependencies due to changes in >2023.3.15 tifffile. This largely just reverts this PRTesting
Unit tests