Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store frame metadata when reading a specific scene #492

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

joshua-gould
Copy link
Contributor

Retrieves scene metadata when a scene is specified

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -5.71 ⚠️

Comparison is base (bed6166) 94.06% compared to head (f6014d5) 88.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   94.06%   88.35%   -5.71%     
==========================================
  Files          48       48              
  Lines        4363     4371       +8     
==========================================
- Hits         4104     3862     -242     
- Misses        259      509     +250     
Impacted Files Coverage Δ
aicsimageio/readers/nd2_reader.py 92.85% <100.00%> (+0.35%) ⬆️
...eio/tests/readers/extra_readers/test_nd2_reader.py 96.15% <100.00%> (+1.15%) ⬆️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue why this can't go through? Tests are failing for unrelated reasons. Thanks for the addition.

Copy link
Collaborator

@SeanLeRoy SeanLeRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@evamaxfield evamaxfield merged commit d4ae290 into AllenCellModeling:main Apr 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants