Fixed error in ata.cpp #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing two times to the Low port instead of writing to the low and the high port
|
Oh I didn't see this, I just submitted an issue for the same thing. I'll link this. |
|
Hasn't been merged in a while though :( |
|
Yeah, seems this is pretty dead. And I can't get the (modified) PIO driver to work even after fixing it. Are there any pitfalls you know of that I could be falling into? |
|
Not really... I haven't had any issues with the code except for this problem |
|
it's probably either my port_byte_in/out function or some off-by-one error, or maybe my qemu config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing two times to the Low port instead of writing to the low and the high port