ACS-930 Security update to spring boot 2.4.1 & Junit 5 #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junit5 upgrade: transformer-base imagemagick
Spring now bundles @ExtendWith(SpringExtension.class) with @WebMvcTest and @SpringBootTest
montgolfiere
changed the title
montgolfiere
approved these changes
Jan 15, 2021
PunchedChimera
deleted the
ATS-ACS-930-acs-security-update-to-spring-boot-2-4-1
branch
|
Thanks @PunchedChimera For ref: David mentioned that previous Spring Boot would run with either JUnit 4 or JUnit 5. However, Spring Boot 2.4.x now supports JUnit 5. Hence, simpler to upgrade the tests rather than attempt to workaround. |
montgolfiere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the recent upgrade to SpringBoot 2.4.1, no tests have been able to execute.
This PR is to upgrade to Junit 5 to re-enable to the tests in Travis.