REPO-5191 Bug: T-Engine should provide mapping rather than the repo. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug found while reviewing documents on how to create a custom metadata extractor. The original refactor had left the repo doing the mapping. It should have been passing the fully qualified repo properties to the T-Engine to do the mapping.
eknidev
approved these changes
Jan 5, 2021
...orm-tika/src/main/java/org/alfresco/transformer/metadataExtractors/PoiMetadataExtractor.java
Outdated
Show resolved
Hide resolved
eknidev
reviewed
Jan 5, 2021
...src/main/java/org/alfresco/transformer/metadataExtractors/AbstractTikaMetadataExtractor.java
Outdated
Show resolved
Hide resolved
alandavis
added a commit
to Alfresco/acs-packaging
that referenced
this pull request
Jan 6, 2021
Linked to bug fix found while writing these docs:
Alfresco/alfresco-community-repo#227
Alfresco/alfresco-transform-core#316
[skip ci] .md files only
alandavis
added a commit
to Alfresco/alfresco-community-repo
that referenced
this pull request
Jan 7, 2021
…227) Bug found while reviewing documents on how to create a custom metadata extractor. The original refactor had left the repo doing the mapping. It should have been passing the fully qualified repo properties to the T-Engine to do the mapping. Linked to: Alfresco/acs-packaging#1826 Alfresco/alfresco-transform-core#316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found while reviewing documents on how to create a custom metadata extractor. The original refactor had left the repo doing the mapping. It should have been passing the fully qualified repo properties to the T-Engine to do the mapping.
Linked to: