Allow repository to be used with ROS/ROS 2 #8783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows this repository to be used directly with the popular robotics middleware ROS by providing a manifest
package.xml
, a simple text file containing its dependencies, that is compatible with ROS as well as ROS 2. Previously this was only possible through wrappers such asdarknet_ros
ordarknet_vendor
that use the initial Darknet which is no longer actively maintained. This is related to previous issue #5457.This change makes integrating Darknet into robotics applications much more convenient. It is sufficient to make the
package.xml
of any package depending on Darknet with<depend>darknet</depend>
and linking to it inside theCMakeList.txt
with:Additionally
INSTALL_RPATH_USE_LINK_PATH
might have to be set.