Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repository to be used with ROS/ROS 2 #8783

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

2b-t
Copy link

@2b-t 2b-t commented Apr 27, 2023

This pull request allows this repository to be used directly with the popular robotics middleware ROS by providing a manifest package.xml, a simple text file containing its dependencies, that is compatible with ROS as well as ROS 2. Previously this was only possible through wrappers such as darknet_ros or darknet_vendor that use the initial Darknet which is no longer actively maintained. This is related to previous issue #5457.

This change makes integrating Darknet into robotics applications much more convenient. It is sufficient to make the package.xml of any package depending on Darknet with <depend>darknet</depend> and linking to it inside the CMakeList.txt with:

find_package(Darknet REQUIRED)
include_directories(
  ${Darknet_INCLUDE_DIR}
)
link_libraries(Darknet::dark)

Additionally INSTALL_RPATH_USE_LINK_PATH might have to be set.

@cenit cenit merged commit 5915c2e into AlexeyAB:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants