Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes in the docs for advanced transitions #1023

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mschinwald
Copy link

Hi 👋

The classes for the hiding transition are wrong in the table in https://floating-vue.starpad.dev/guide/css#advanced-transitions, so I changed them accordingly.

Also, I realized that if you follow the docs and change the transition of .v-popper__wrapper, you also have to change the transition of its parent (.v-popper__popper). So if your transition takes .5 seconds for example, you wouldn't be able to see the whole transition because of the parent's transition that takes only .15 seconds.

You can see an example of this in this stackblitz: https://stackblitz.com/edit/vue-fyqfc2?file=src%2FApp.vue,src%2Fmain.js

So I added a little note about it. I'm not sure if I explained it well and if it needs to be in the docs, but it probably would have saved me some time.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for v-tooltip ready!

Name Link
🔨 Latest commit fd62511
🔍 Latest deploy log https://app.netlify.com/sites/v-tooltip/deploys/65bc28f7c6e2250007268c54
😎 Deploy Preview https://deploy-preview-1023--v-tooltip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant