Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar redraw on seek to start position #426

Merged

Conversation

Emzawadzki
Copy link
Contributor

This PR should fix the issue #425

@SangwonOh SangwonOh self-requested a review May 21, 2024 10:39
@@ -282,15 +282,15 @@ const ProgressBar = function ($container, api, isAd, metadata) {

if (isAd) {
api.on(AD_TIME, function (data) {
if (data && data.duration && data.position) {
if (data && data.duration && typeof data.position === "number") {
Copy link
Contributor Author

@Emzawadzki Emzawadzki May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be a good practice to add the same check also for data.duration, but I guess it doesn't matter when duration is 0.

Copy link
Member

@SangwonOh SangwonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that your code solves it well. Thanks for your contribution.

@SangwonOh SangwonOh merged commit a0b6797 into AirenSoft:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants