Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check park on Judge #116

Merged
merged 1 commit into from
Apr 20, 2019
Merged

feat: add check park on Judge #116

merged 1 commit into from
Apr 20, 2019

Conversation

himself65
Copy link
Member

No description provided.

@himself65 himself65 added the enhancement New feature or request label Apr 13, 2019
@himself65 himself65 added this to the core milestone Apr 13, 2019
@himself65 himself65 self-assigned this Apr 13, 2019
@himself65 himself65 marked this pull request as ready for review April 13, 2019 14:37
@codecov-io
Copy link

codecov-io commented Apr 13, 2019 •
edited
Loading

Codecov Report

Merging #116 into master will increase coverage by 1.15%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   85.43%   86.58%   +1.15%     
==========================================
  Files          12       11       -1     
  Lines         151      164      +13     
  Branches       39       40       +1     
==========================================
+ Hits          129      142      +13     
  Misses         19       19              
  Partials        3        3
Impacted Files Coverage Δ
packages/rrreol-core/src/judge.js 77.77% <85.18%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190939c...df7555a. Read the comment docs.

@himself65 himself65 force-pushed the judge branch 3 times, most recently from 11fb3e6 to 2a85f9c Compare April 13, 2019 17:40
@himself65 himself65 force-pushed the judge branch 6 times, most recently from 02502b8 to 4a3a7f6 Compare April 14, 2019 03:18
@himself65 himself65 mentioned this pull request Apr 14, 2019
Open
@langyo
Copy link

langyo commented Apr 15, 2019

mhmmmmmmm...

@himself65
feat: add check park on Judge
df7555a 
Signed-off-by: himself65 <himself6565@gmail.com>
@himself65
Copy link
Member Author

codecov/patch — 85.18% of diff hit (target 85.43%) 不管了, 因为已经patch已经全部覆盖了

@himself65 himself65 merged commit 26712c4 into AimonaStudio:master Apr 20, 2019
@himself65 himself65 deleted the judge branch April 20, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himself65 himself65

Labels
enhancement New feature or request
Projects
Project Main Plans
  
Awaiting triage
Milestone
core
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@himself65 @codecov-io @langyo