Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missed a duplication of #5569 patch #5573

Merged
merged 1 commit into from
Jun 10, 2022
Merged

fix: missed a duplication of #5569 patch #5573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/agoric-cli/test/test-main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/* global globalThis */
import '@endo/init/pre.js';
import 'esm';
// Not yet '@endo/init/debug.js' because esm needs moderate override taming
import '@endo/init';
import '@endo/init/debug.js';
import test from 'ava';
import fs from 'fs';
import anylogger from 'anylogger';
Expand Down
50 changes: 50 additions & 0 deletions patches/@confio+ics23++protobufjs+6.11.3.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
diff --git a/node_modules/@confio/ics23/node_modules/protobufjs/src/util/minimal.js b/node_modules/@confio/ics23/node_modules/protobufjs/src/util/minimal.js
index 3c406de..083f71c 100644
--- a/node_modules/@confio/ics23/node_modules/protobufjs/src/util/minimal.js
+++ b/node_modules/@confio/ics23/node_modules/protobufjs/src/util/minimal.js
@@ -280,13 +280,38 @@ function newError(name) {
merge(this, properties);
}

- (CustomError.prototype = Object.create(Error.prototype)).constructor = CustomError;
-
- Object.defineProperty(CustomError.prototype, "name", { get: function() { return name; } });
-
- CustomError.prototype.toString = function toString() {
- return this.name + ": " + this.message;
- };
+ CustomError.prototype = Object.create(Error.prototype, {
+ constructor: {
+ value: CustomError,
+ writable: true,
+ // enumerable: true would accurately preserve the behavior of the
+ // original assignment, but I'm guessing that was not intentional.
+ // For an actual error subclass, this property would not
+ // be enumerable.
+ enumerable: false,
+ configurable: true,
+ },
+ name: {
+ get() { return name; },
+ set: undefined,
+ enumerable: false,
+ // configurable: false would accurately preserve the behavior of
+ // the original, but I'm guessing that was not intentional.
+ // For an actual error subclass, this property would
+ // be configurable.
+ configurable: true,
+ },
+ toString: {
+ value() { return this.name + ": " + this.message; },
+ writable: true,
+ // enumerable: true would accurately preserve the behavior of the
+ // original assignment, but I'm guessing that was not intentional.
+ // For an actual error subclass, this property would not
+ // be enumerable.
+ enumerable: false,
+ configurable: true,
+ },
+ });

return CustomError;
}