Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch mistaken overrides #5569

Merged
merged 2 commits into from
Jun 10, 2022
Merged

fix: patch mistaken overrides #5569

merged 2 commits into from
Jun 10, 2022

Conversation

erights
Copy link
Member

@erights erights commented Jun 10, 2022

Patch mistaken overrides.

These were the overrides that prevent us from changing


to

import '@endo/init/debug.js';

at
#5567
since debug.js also sets overrideTaming to 'min' as it should, in order to catch such problems.

@erights erights self-assigned this Jun 10, 2022
@erights erights requested review from kriskowal and turadg June 10, 2022 19:45
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does enumerable: true cause the problem?

Approving since I assume you have a good answer : )

@erights
Copy link
Member Author

erights commented Jun 10, 2022

Why does enumerable: true cause the problem?

Approving since I assume you have a good answer : )

Clarified by adding

+            // enumerable: true would accurately preserve the behavior of the
+            // original assignment, but I'm guessing that was not intentional.
+            // For an actual error subclass, this property would not
+            // be enumerable.

to all the relevant enumerable: false cases.

@erights erights added the automerge:squash Automatically squash merge label Jun 10, 2022
@mergify mergify bot merged commit 93f0a77 into master Jun 10, 2022
@mergify mergify bot deleted the markm-patch-bad-overrides branch June 10, 2022 22:10
Chris-Hibbert pushed a commit that referenced this pull request Jun 13, 2022
* fix: patch mistaken overrides

* fix: clarifying for review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants