Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getPublicFacet accepts promise for instance #4328

Merged
merged 2 commits into from
Jan 21, 2022
Merged

fix: getPublicFacet accepts promise for instance #4328

merged 2 commits into from
Jan 21, 2022

Conversation

erights
Copy link
Member

@erights erights commented Jan 20, 2022

Fixes #3837

@erights erights self-assigned this Jan 20, 2022
Chris-Hibbert
Chris-Hibbert approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please add a test.

@erights erights added the automerge:squash Automatically squash merge label Jan 21, 2022
@mergify mergify bot merged commit f716199 into master Jan 21, 2022
@mergify mergify bot deleted the 3837-markm-promisify-getPublicFacet branch January 21, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

Assignees

@erights erights

Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zoe.getPublicFacet(instance) should accept a promise
2 participants
@erights @Chris-Hibbert