feat(agoric-cli): Support Node.js ESM deploy scripts #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2021
michaelfig
approved these changes
Aug 15, 2021
packages/agoric-cli/lib/deploy.js
Outdated
Comment on lines
251
to
252
| : // eslint-disable-next-line import/no-dynamic-require | ||
| require(modulePath); |
There was a problem hiding this comment.
Please do the renaming needed to make this suggestion possible:
Suggested change
| : // eslint-disable-next-line import/no-dynamic-require | |
| require(modulePath); | |
| : esmRequire(modulePath); |
michaelfig
reviewed
Aug 15, 2021
packages/agoric-cli/lib/deploy.js
Outdated
|
|
||
| // Use Node.js ESM support if package.json of template says "type": | ||
| // "module". | ||
| const packageFile = pathResolve('package.json'); |
There was a problem hiding this comment.
Oh, another thing: the package.json should be searched starting from the moduleFile, since it is possible that the moduleFile is in a different subpackage than the top-level package.json.
There was a problem hiding this comment.
I resolved this by bringing in a utility in compartment mapper that searches for the package.json above any file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #527
This adds support for Node.js ESM deploy scripts, allowing dapps to be created
or refactored using Node.js ESM instead of the
standardthings/esmemulation.To test this feature, I created a
nesmbranch of thedapp-fungible-faucetdapp that was converted to Node.js ESM with
"type": "module"inpackage.jsonand verified through a console log thatagoric deploychose touse the Node.js ESM implementation. For good measure, I added a temporary
useless reference to
import.meta.url, which is not properly emulated by-r esm.This necessitated an additional feature to
agoric init, to specify thebranch to use from the template dapp.