refactor(treasury): Convert RESM to NESM #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
527-treasury
branch
from
50a07e0
to
b1f825f
Compare
|
I think @Chris-Hibbert is better suited for this review. |
katelynsills
requested review from
Chris-Hibbert
and removed request for
katelynsills
Chris-Hibbert
requested changes
Aug 10, 2021
|
|
||
| async function writeSourceBundle(contractFilename, outputPath) { | ||
| const path = require.resolve(contractFilename); | ||
| const path = new URL(await importMetaResolve(contractFilename, import.meta.url)).pathname; |
There was a problem hiding this comment.
eslint should be asking for a line break here. If it doesn't insist, we should break anyway for consistency.
Also there's a non-top-level await embedded here.
| @@ -28,7 +34,7 @@ const makeInstall = async (root, zoe) => { | |||
|
|
|||
| test('bootstrap payment', async t => { | |||
| const zoe = makeZoe(fakeVatAdmin); | |||
| const autoswapInstall = await makeInstall(autoswapRoot, zoe); | |||
| const autoswapInstall = await makeInstall(await autoswapRoot, zoe); | |||
There was a problem hiding this comment.
This is a non-top-level await. Is that going to be allowed? Can we put the await inside makeInstall() instead?
packages/treasury/test/test-vault.js
Outdated
| @@ -46,7 +46,8 @@ trace('makeZoe'); | |||
| * @param {string} sourceRoot | |||
| */ | |||
| async function launch(zoeP, sourceRoot) { | |||
| const contractBundle = await bundleSource(require.resolve(sourceRoot)); | |||
| const contractPath = new URL(await importMetaResolve(sourceRoot, import.meta.url)).pathname; | |||
There was a problem hiding this comment.
await is not top-level here.
kriskowal
force-pushed
the
527-stat-logger
branch
from
7d12ddb
to
c457a83
Compare
kriskowal
force-pushed
the
527-treasury
branch
2 times, most recently
from
55c4115
to
e0409c5
Compare
kriskowal
force-pushed
the
527-stat-logger
branch
from
2fc9441
to
ceba76f
Compare
kriskowal
force-pushed
the
527-treasury
branch
2 times, most recently
from
61589dc
to
416ef36
Compare
kriskowal
force-pushed
the
527-treasury
branch
from
416ef36
to
87d915e
Compare
kriskowal
force-pushed
the
527-treasury
branch
from
87d915e
to
fe4b988
Compare
kriskowal
force-pushed
the
527-treasury
branch
from
fe4b988
to
bfa7fb3
Compare
kriskowal
force-pushed
the
527-stat-logger
branch
from
4d764f9
to
bd992a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #527