use metered=true on all dynamic vats, xs-worker on all swingset tests #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swingset will soon change from "all dynamic vats are metered" to "dynamic vats are unmetered by default", so set "metered: true" to retain the current behavior for ZCF vats. In addition, metering is going to be removed from the "local" (Node.js) vat-worker, so "metered: true" will require "xs-worker" (xsnap) instead. This changes the `tests/swingsetTests` runners to use xs-worker. Note that this upcoming change means any application which uses Zoe to spawn ZCF vats must run with `config.defaultManagerType='xs-worker'`, otherwise vat creation will fail when Zoe asks for a metered vat. Our two primary applications (the chain and the solo machine) both do this already. refs #3518 refs #3308
since this will no longer be the default soon
warner
added
SwingSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swingset will soon change from "all dynamic vats are metered" to "dynamic vats are unmetered by default", so set "metered: true" to retain the current behavior for ZCF vats.
In addition, metering is going to be removed from the "local" (Node.js) vat-worker, so "metered: true" will require "xs-worker" (xsnap) instead. This changes the
tests/swingsetTestsrunners to use xs-worker.Note that this upcoming change means any application which uses Zoe to spawn ZCF vats must run with
config.defaultManagerType='xs-worker', otherwise vat creation will fail when Zoe asks for a metered vat. Our two primary applications (the chain and the solo machine) both do this already.refs #3518
refs #3308