Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate purse filtering by brand #2798

Merged
merged 2 commits into from
Apr 4, 2021
Merged

feat: separate purse filtering by brand #2798

merged 2 commits into from
Apr 4, 2021

Conversation

dtribble
Copy link
Member

@dtribble dtribble commented Apr 3, 2021

  • make separate helper function for filtering purses by brand
  • don't automatially selec the first purse
    -don't automatically filter purses by brand

The app model needs to line up with the purse selection, and auto-selecting complicates that.

- make separate helper function for filtering purses by brand
- don't automatially selec the first purse
-don't automatically filter purses by brand

The app model needs to line up with the purse selection, and auto-selecting complicates that.
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtribble dtribble enabled auto-merge (squash) April 4, 2021 02:08
@dtribble dtribble merged commit a02585e into master Apr 4, 2021
@dtribble dtribble deleted the purse_filter branch April 4, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants