Let errorTaming default to safe #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-lockdown-safe-errorTaming
branch
from
38f6a1e
to
45a4a4b
Compare
erights
force-pushed
the
markm-lockdown-safe-errorTaming
branch
from
45a4a4b
to
444578c
Compare
erights
changed the title
dckc
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
errorTaming: 'unsafe'setting left the unsafe.stackproperty on error instances as an uncontrolled source of information that is both non-deterministic and encapsulation violating. (See https://github.com/endojs/endo/blob/master/packages/ses/lockdown-options.md )This PR has been draft for a while because something was failing under CI with this change. With CI now green, this PR is ready for review.