Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make brand optional in the types of getAmountAllocated #1760

Merged
merged 5 commits into from
Sep 15, 2020
Merged

fix: make brand optional in the types of getAmountAllocated #1760

merged 5 commits into from
Sep 15, 2020

Conversation

katelynsills
Copy link
Contributor

Closes #1725

@katelynsills katelynsills added the Zoe package: Zoe label Sep 14, 2020
@katelynsills katelynsills self-assigned this Sep 14, 2020
Chris-Hibbert
Chris-Hibbert reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. I have questions about the error message.

packages/zoe/src/contractFacet/seat.js Outdated Show resolved Hide resolved
Chris-Hibbert
Chris-Hibbert approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, that was supposed to be approval. I have questions, but leave the resolution to your judgement.

@katelynsills katelynsills merged commit 3a98491 into master Sep 15, 2020
@katelynsills katelynsills deleted the 1725-brand-optional branch September 15, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert approved these changes

Assignees

@katelynsills katelynsills

Labels
Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zcf.getAmountAllocated should either assert a brand argument or allow it to be optional
2 participants
@katelynsills @Chris-Hibbert