Zoe Release Candidate #1414
Merged
Zoe Release Candidate #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…worked for new synchronous mint still
- `getInviteIssuer` to `getInvitationIssuer` - `inviteDesc` to `description`
zcf.addEmptySeat() would return a zcfSeat that the contract could use to hold allocations. untested
drop keyword parameter in addEmptySeat() extract makeZoeSeatAdminKit, use it for emptySeat, too. rename zcf seat construction to use 'Kit'
refactor: add types to reveal the wallet changes needed for Zoe
improved type annotations rename makeEmptySeat to makeOfferlessSeat don't return the zcfSeatAdmin to the contract
feat: add the ability for a contract to get a synchronous seat
fix: make Zoe typesafe again
Based on the synchronous seat work. The unit tests for autoswap pass. I haven't yet done the swingset tests.
refactor: bring autoswap up to date on the new Zoe spike branch
Closed
|
Might as well keep track of it here. The files I'm signing up to review are those in Of If there are other specific contracts that you think I should review, let me know. I am not signing up to review anything in Is there any better way to keep track of who reviews which files? |
|
On |
This was referenced Aug 17, 2020
This was referenced Aug 17, 2020
* chore: address PR comments about exit behavior * Update packages/zoe/src/zoeService/zoeSeat.js Co-authored-by: Mark S. Miller <erights@users.noreply.github.com> * chore: fix lint, slight errors from merge Co-authored-by: Mark S. Miller <erights@users.noreply.github.com>
This was referenced Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR captures the release candidate for Zoe. We expect all current tests to pass for this branch before merging into master, and once this branch is merged into master, a round of serious testing (in which tests are added and security claims are analyzed) will be done.
#dapp-encouragement-branch: new-zoe
Closes #836
Closes #782
Closes #1016
Closes #1267
Closes #1378
Closes #1210
Closes #1444
Closes #1442
Closes #1451
Closes #1452
Closes #1459
Closes #1455
Closes #1421