fix(swingset): check promise resolution table during comms.inbound #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
1400-comms-bug
branch
2 times, most recently
from
0904e3d
to
47746aa
Compare
|
@dtribble said it fixed the failures he saw, treating that as a r+ from him |
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1400
This fixes the case where a cross-machine message is pipelined to a result promise that gets resolved before that message arrives. Previously the receiving comms vat would mistakenly deliver it into the kernel to the old promise-ID, which the kernel has forgotten by that point. Now the comms vat references its internal promise table on the way in, so the message is delivered into the kernel to the new object-ID.