feat(swingset): add subprocess+node -based VatManager #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
1374-vatworker-subprocess-node
branch
from
df51422
to
e392559
Compare
FUDCo
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Seems like a straightforward extrapolation from #1386, though it amplifies my earlier concerns about the tension between on the one hand allowing host-specific stuff to support disparate hosts and on the other hand having good modularity. In particular, once we are supporting XS it's probably not going to be good for people doing stuff on Node to have to import a bunch of XS stuff and vice versa, which looks like the trend line this is on.
This adds a new `managerType` named `'subprocess-node'`, which runs Node.js in a subprocess, and sends it netstring-wrapped JSON-encoded Delivery/Syscall objects to drive the vat. It currently has the same limitations as the thread-based worker: * vatPowers is missing transformTildot * metering is not implemented at all * delivery transcripts (and replay) are not yet implemented In addition, it does not yet use a blocking read for syscall responses, so it can not yet invoke devices. However, unlike the thread worker, blocking reads should be possible for a subprocess, so eventually we will have this ability. refs #1374
warner
force-pushed
the
1384-vatworker-thread
branch
from
6e37904
to
61615a2
Compare
warner
force-pushed
the
1374-vatworker-subprocess-node
branch
from
e392559
to
184c912
Compare
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
managerTypenamed'subprocess-node', which runs Node.jsin a subprocess, and sends it netstring-wrapped JSON-encoded Delivery/Syscall
objects to drive the vat.
It currently has the same limitations as the thread-based worker:
In addition, it does not yet use a blocking read for syscall responses, so it
can not yet invoke devices. However, unlike the thread worker, blocking reads
should be possible for a subprocess, so eventually we will have this ability.
refs #1374