Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundle-source): fix comment misparse, make require optional #1320

Merged
merged 4 commits into from
Jul 22, 2020
Merged

fix(bundle-source): fix comment misparse, make require optional #1320

merged 4 commits into from
Jul 22, 2020

Conversation

michaelfig
Copy link
Member

Closes: #1281, closes: #362

Now, the require endowment is optional.

Also, bundling // */ BAD CODE no longer evaluates BAD CODE.

@michaelfig michaelfig added the bundle-source package: bundle-source label Jul 21, 2020
@michaelfig michaelfig requested review from warner and FUDCo July 21, 2020 20:30
@michaelfig michaelfig self-assigned this Jul 21, 2020
warner
warner approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but think about the questions briefly

packages/bundle-source/src/index.js Show resolved Hide resolved
packages/bundle-source/src/index.js Show resolved Hide resolved
packages/bundle-source/test/sanity.js Show resolved Hide resolved
FUDCo
FUDCo approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though I instinctively distrust anything that uses regular expressions :-)

@michaelfig michaelfig merged commit 62797d5 into master Jul 22, 2020
@michaelfig michaelfig deleted the mfig/bundle-source-errors branch July 22, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

@FUDCo FUDCo FUDCo approved these changes

Assignees

@michaelfig michaelfig

Labels
bundle-source package: bundle-source
Projects
None yet
Milestone
No milestone
3 participants
@michaelfig @warner @FUDCo