Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn install changes line in go.mod #115

Merged
merged 1 commit into from
Dec 3, 2019
Merged

yarn install changes line in go.mod #115

merged 1 commit into from
Dec 3, 2019

Conversation

katelynsills
Copy link
Contributor

This change happens automatically on yarn install.

Closes #114

@katelynsills katelynsills changed the title yarn install makes this change yarn install changes line in go.mod Dec 3, 2019
michaelfig
michaelfig approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on the version of Go you're using. I have 1.12.5 and it wants to keep the appengine dependency line.

Which version are you running? If it's later, then LGTM. Otherwise, let's leave this as is.

@katelynsills
Copy link
Contributor Author

I have go version go1.13.3 darwin/amd64, so it's later. Thanks, @michaelfig I'll merge!

@katelynsills katelynsills merged commit 26a788e into master Dec 3, 2019
@katelynsills katelynsills deleted the 114-remove-go.mod-line branch December 3, 2019 18:01
dckc pushed a commit to dckc/agoric-sdk that referenced this pull request Dec 5, 2019
@jfparadis
feat(wallet): Make purses observable (Agoric#115)
53e56fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarn install changes packages/cosmic-swingset/go.mod
2 participants
@katelynsills @michaelfig