Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ag-chain-cosmos unsafe-reset-all needs to reset kernel state too #433

Closed
michaelfig opened this issue Jan 21, 2020 · 1 comment · Fixed by #434
Closed

ag-chain-cosmos unsafe-reset-all needs to reset kernel state too #433

michaelfig opened this issue Jan 21, 2020 · 1 comment · Fixed by #434
Labels
cosmic-swingset package: cosmic-swingset

Comments

@michaelfig
Copy link
Member

When a validator runs ag-chain-cosmos unsafe-reset-all, the kernel state file should also be reset.

To accomplish that, the kernel state should be kept with all other validator state in $HOME/.ag-chain-cosmos/data/ag-cosmos-chain-state.json. If we ever move that validator directory elsewhere, the kernel state should also move, too.

@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label Jan 21, 2020
@michaelfig
Copy link
Member Author

michaelfig commented Jan 21, 2020

@mabalaru, @awrelll, @warner this proposal would mitigate misbehaviour for people who are accustomed to using Tendermint but not aware that the Agoric state is a different beast. By putting it in the same data directory, it will be backed up, deleted, viewed, etc. at the same time as other validator runtime data.

michaelfig added a commit that referenced this issue Jan 21, 2020
Closes #433

We try our best to find the actual Cosmos state directory.
michaelfig added a commit that referenced this issue Jan 21, 2020
Closes #433

We try our best to find the actual Cosmos state directory.
michaelfig added a commit that referenced this issue Jan 21, 2020
…434)

Closes #433

We try our best to find the actual Cosmos state directory, either `$HOME/.ag-chain-cosmos`, or `$AG_CHAIN_COSMOS_HOME` or `--home=DIR`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant