Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify scheduling in distributeFees #3044

Closed
Chris-Hibbert opened this issue May 6, 2021 · 0 comments · Fixed by #3051
Closed

simplify scheduling in distributeFees #3044

Chris-Hibbert opened this issue May 6, 2021 · 0 comments · Fixed by #3051
Assignees
Labels
code-style defensive correctness patterns; readability thru consistency Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request hygiene Tidying up around the house technical-debt

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

vats/src/distributeFees.js tries to throttle multiple deposits in too complex a way.

Description of the Design

@michaelfig said

if we still need the deposit-to-all functionality, we should rip out the batching/queuing/depositMultiple/delays and just fire off Promise.all(accounts.map(acct, i) => E(bank).deposit(acct, payment[i])), and let the scheduler decide how to handle many messages. It was premature optimisation, and in the wrong place (any changes to make this efficient should be made in the scheduler instead of per-vat).

Security Considerations

Should be performance only.

Test Plan

existing tests should be sufficient, since the code will get simpler and require fewer parameters.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request hygiene Tidying up around the house Small Core Economy OBSOLETE in favor of INTER-protocol code-style defensive correctness patterns; readability thru consistency technical-debt labels May 6, 2021
@Chris-Hibbert Chris-Hibbert added this to the Beta Phase 4: Governance milestone May 6, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this May 6, 2021
Chris-Hibbert added a commit that referenced this issue May 6, 2021
Chris-Hibbert added a commit that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-style defensive correctness patterns; readability thru consistency Core Economy OBSOLETE in favor of INTER-protocol enhancement New feature or request hygiene Tidying up around the house technical-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant