Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change 'Trade Successful' offerResult to 'Order Added' #1651

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

katelynsills
Copy link
Contributor

Closes #1640

@katelynsills katelynsills added the Zoe package: Zoe label Aug 31, 2020
@katelynsills katelynsills self-assigned this Aug 31, 2020
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by review. LGTM!

Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@katelynsills katelynsills merged commit 7da7f58 into master Sep 1, 2020
@katelynsills katelynsills deleted the 1640-trade-successful branch September 1, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SimpleExchange OfferResult of "Trade Successful" is the wrong message for adding to the order book
3 participants