Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleExchange OfferResult of "Trade Successful" is the wrong message for adding to the order book #1640

Closed
katelynsills opened this issue Aug 28, 2020 · 2 comments · Fixed by #1651
Closed

SimpleExchange OfferResult of "Trade Successful" is the wrong message for adding to the order book #1640

katelynsills opened this issue Aug 28, 2020 · 2 comments · Fixed by #1651
Assignees
@katelynsills
Labels
Zoe package: Zoe

Comments

@katelynsills
Copy link
Contributor

What is the Problem Being Solved?
Currently we are returning the message "Trade successful" when an order is added to the order book in Simple Exchange. This is misleading, because the trade has not yet happened. We should return a message that says the order has been added to the exchange.

Screen Shot 2020-08-28 at 2 57 33 PM

Description of the Design
Change the message returned.

Security Considerations

None.

Test Plan
Change the offerResult tests for simpleExchange.
@katelynsills katelynsills added the Zoe package: Zoe label Aug 28, 2020
@katelynsills katelynsills self-assigned this Aug 28, 2020
@erights
Copy link
Member

erights commented Aug 28, 2020

"Security Considerations: None." is misleading. A user thinking a trade happened when it did not opens the door to many attacks.

@katelynsills
Copy link
Contributor Author

"Security Considerations: None." is misleading. A user thinking a trade happened when it did not opens the door to many attacks.

Good point

@katelynsills katelynsills mentioned this issue Aug 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katelynsills katelynsills

Labels
Zoe package: Zoe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change 'Trade Successful' offerResult to 'Order Added' Agoric/agoric-sdk
2 participants
@erights @katelynsills