Merge pull request #3100 from Agoric/mfig-enable-coverage

Enable coverage reporting

.github/workflows/ag-solo-xs.yml.DISABLED

@@ -18,7 +18,7 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-node@v1
       with:
-        node-version: '12.14.1'
+        node-version: '12.x'
     - name: cache node modules
       uses: actions/cache@v1
       with:

.github/workflows/test-all-packages.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/checkout@v2
       with:
@@ -117,6 +117,58 @@ jobs:
         name: benchmarkstats.json
         path: packages/swingset-runner/benchstats*.json
 
+  coverage:
+    needs: build
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node-version: ['14.x']
+    if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
+    steps:
+    - uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    # BEGIN-RESTORE-BOILERPLATE
+    - name: restore built files
+      id: built
+      uses: actions/cache@v1
+      with:
+        path: .
+        key: ${{ runner.os }}-${{ matrix.node-version }}-built-${{ github.sha }}
+    - uses: actions/checkout@v2
+      with:
+        submodules: 'true'
+      if: steps.built.outputs.cache-hit != 'true'
+    - name: yarn install
+      run: yarn install
+      if: steps.built.outputs.cache-hit != 'true'
+    - name: yarn build
+      run: yarn build
+      if: steps.built.outputs.cache-hit != 'true'
+    # END-RESTORE-BOILERPLATE
+
+    - name: generate coverage for all tests
+      run: 'yarn test:c8-all || :'
+    - name: generate coverage/html reports
+      run: yarn c8 report --reporter=html-spa --reports-dir=coverage/html --temp-directory=coverage/tmp
+    - uses: actions/upload-artifact@v2
+      with:
+        name: coverage
+        path: coverage
+    - name: Find Netlify site ID
+      run: |
+        echo "NETLIFY_SITE_ID=$(cat COVERAGE_NETLIFY_SITE_ID)" >> $GITHUB_ENV
+
+    - uses: nwtgck/actions-netlify@v1.1
+      with:
+        # Production deployment if a commit to master.
+        production-deploy: ${{ github.ref == 'refs/heads/master' }}
+        publish-dir: coverage/html
+        # SECURITY: we don't want to hand out the Github token to this action.
+        # github-token: ${{ secrets.GITHUB_TOKEN }}
+      env:
+        NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
+
 ##################
 # Fast-running tests run as a group:
   test-quick:
@@ -125,7 +177,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -254,7 +306,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -320,7 +372,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -358,7 +410,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -405,7 +457,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:
@@ -450,7 +502,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: ['12.14.1', '12.x', '14.x']
+        node-version: ['12.x', '14.x']
     steps:
     - uses: actions/setup-node@v1
       with:

COVERAGE.md

@@ -0,0 +1,72 @@
+# Coverage reports
+
+## Caveat
+
+Until each module can be migrated to support Node.js's builtin ESM
+implementation (`nesm`), the coverage line numbers will be out-of-sync with
+reality.
+
+In addition, we will have to implement source maps in all of our
+source-to-source transforms (such as `@agoric/bundle-source`,
+`@agoric/transform-metering`, and `@agoric/static-module-record`).
+
+## Reports
+
+Coverage reports for the current main branch (whose packages support `nesm`) are
+published by CI to: https://agoric-sdk-coverage.netlify.app
+
+You can create a report in any package (including the top-level directory):
+
+```sh
+# Get options available for coverage:
+yarn c8 --help
+# Run ava under Node.js coverage and display a summary:
+yarn c8 -a ava
+# Generate a nice, detailed HTML report:
+yarn c8 report --reporter=html-spa
+open coverage/html/index.html
+```
+
+## Node.js ESM Support
+
+With the current `patches/esm+3.2.25.diff`, it is possible to migrate packages
+to support both resm (`-r esm`) and nesm (Node.js ESM Support).  If an
+`agoric-sdk` package has dependencies that support nesm, you can attempt to make
+it also support nesm by:
+
+1. Create `ava-nesm.config.js` removing `"require": ["esm"]`:
+
+```sh
+../../scripts/ava-nesm.cjs > ava-nesm.config.js
+```
+
+2. Make the following changes to its `package.json` (omitting comments):
+
+```js
+{
+  // Enable nesm support.
+  "type": "module",
+  "scripts": {
+    // The following line enables coverage generation from the top.
+    "test:c8": "c8 $C8_OPTIONS ava --config=ava-nesm.config.js"
+  }
+}
+```
+
+3. Test that both `yarn test` and `yarn test:c8` run correctly.
+
+## Planned Implementation
+
+Our runtime source transforms can be conditional on the `$NODE_V8_COVERAGE`
+environment variable, which is set by `c8`.
+
+When that is nonempty, source transforms can implement special behaviour to
+preserve source maps for transformed code.  This involves using a `//#
+sourceURL=...` tag to associate a unique URL to an actual existing file during
+`eval`.  The file's contents include a `//# sourceMappingURL=...`, whether a
+relative URL (taken from `sourceURL`) to a `.js.map` file or inline as a `data:`
+URI.
+
+
+The `sourceMappingURL` source map must contain a `"sources"` property as a
+relative or absolute URL to the input source file.

COVERAGE_NETLIFY_SITE_ID

@@ -0,0 +1 @@
+91d78371-7395-4779-8367-0c4f7088297c

golang/cosmos/package.json

@@ -14,7 +14,6 @@
     "test": "exit 0",
     "build:gyp": "make compile-gyp",
     "build:gyp-debug": "make compile-gyp GYP_DEBUG=--debug",
-    "test:nyc": "nyc ava",
     "test:xs": "exit 0",
     "build": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",

package.json

@@ -49,6 +49,7 @@
   "devDependencies": {
     "@typescript-eslint/parser": "^4.18.0",
     "ava": "^3.12.1",
+    "c8": "^7.7.2",
     "eslint": "^7.23.0",
     "eslint-config-airbnb-base": "^14.0.0",
     "eslint-config-jessie": "^0.0.4",
@@ -58,7 +59,6 @@
     "eslint-plugin-jsx-a11y": "^6.2.3",
     "eslint-plugin-prettier": "^3.1.2",
     "lerna": "^3.20.2",
-    "nyc": "^15.1.0",
     "prettier": "^1.18.2",
     "typescript": "^4.2.3"
   },
@@ -75,13 +75,23 @@
     "lint-fix": "yarn workspaces run lint-fix",
     "lint-check": "yarn workspaces run lint-check",
     "lint": "yarn workspaces run lint-check",
-    "test": "yarn workspaces run test",
+    "test": "ava",
+    "test:c8-all": "rm -rf coverage/tmp && C8_OPTIONS=\"--clean=false --temp-directory=$PWD/coverage/tmp\" lerna run test:c8",
     "test:xs": "yarn workspaces run test:xs",
     "build": "yarn workspaces run build",
     "postinstall": "patch-package",
     "patch-package": "patch-package",
     "build-xs-worker": "cd packages/xs-vat-worker && yarn build:xs-lin"
   },
+  "ava": {
+    "files": [
+      "packages/*/test/**/test-*.js"
+    ],
+    "require": [
+      "esm"
+    ],
+    "timeout": "30m"
+  },
   "dependencies": {
     "patch-package": "^6.2.2"
   }

packages/ERTP/package.json

@@ -15,7 +15,6 @@
     "test:xs": "yarn test:xs-unit && yarn test:xs-worker",
     "test:xs-unit": "ava-xs",
     "test:xs-worker": "SWINGSET_WORKER_TYPE=xs-worker ava -c 2 test/swingsetTests/**/test-*.js",
-    "test:nyc": "nyc ava",
     "pretty-fix": "prettier --write '**/*.js'",
     "pretty-check": "prettier --check '**/*.js'",
     "lint-fix": "yarn lint:eslint --fix && yarn lint:types",
@@ -57,8 +56,7 @@
     "@agoric/install-ses": "^0.5.13",
     "@agoric/swingset-vat": "^0.17.2",
     "ava": "^3.12.1",
-    "esm": "^3.2.25",
-    "nyc": "^15.1.0"
+    "esm": "^3.2.25"
   },
   "files": [
     "src",

packages/SwingSet/package.json

@@ -29,8 +29,7 @@
   "devDependencies": {
     "@agoric/install-metering-and-ses": "^0.2.13",
     "@agoric/ses-ava": "^0.1.1",
-    "ava": "^3.12.1",
-    "nyc": "^15.1.0"
+    "ava": "^3.12.1"
   },
   "dependencies": {
     "@agoric/assert": "^0.2.12",

packages/agoric-cli/package.json

@@ -13,7 +13,7 @@
   ],
   "scripts": {
     "build": "exit 0",
-    "test": "ava --config .ava-unit-test.config.js",
+    "test": "ava",
     "test:xs": "exit 0",
     "integration-test": "ava --config .ava-integration-test.config.js",
     "lint-check": "eslint '**/*.{js,jsx}'",
@@ -22,7 +22,6 @@
   "devDependencies": {
     "@agoric/swingset-vat": "^0.17.2",
     "ava": "^3.12.1",
-    "nyc": "^15.1.0",
     "tmp": "^0.1.0"
   },
   "dependencies": {
@@ -59,6 +58,11 @@
       "@agoric"
     ]
   },
+  "ava": {
+    "files": ["test/**/test-*.js"],
+    "require": ["esm"],
+    "timeout": "2m"
+  },
   "prettier": {
     "trailingComma": "all",
     "singleQuote": true

packages/assert/package.json

@@ -37,8 +37,7 @@
   "devDependencies": {
     "@agoric/install-ses": "^0.5.13",
     "ava": "^3.12.1",
-    "esm": "^3.2.25",
-    "nyc": "^15.1.0"
+    "esm": "^3.2.25"
   },
   "files": [
     "src/",

packages/bundle-source/package.json

@@ -9,7 +9,6 @@
   "scripts": {
     "build": "exit 0",
     "test": "ava",
-    "test:nyc": "nyc ava",
     "test:xs": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint-check": "eslint '**/*.js'",
@@ -18,8 +17,7 @@
   },
   "devDependencies": {
     "@agoric/install-ses": "^0.5.13",
-    "ava": "^3.12.1",
-    "nyc": "^15.1.0"
+    "ava": "^3.12.1"
   },
   "dependencies": {
     "@agoric/compartment-mapper": "^0.2.4",

packages/captp/package.json

@@ -29,15 +29,13 @@
   "scripts": {
     "build": "exit 0",
     "test": "ava",
-    "test:nyc": "nyc ava",
     "test:xs": "exit 0",
     "lint-fix": "eslint --fix '**/*.js'",
     "lint-check": "eslint 'lib/*.js'"
   },
   "devDependencies": {
     "@agoric/install-ses": "^0.5.13",
-    "ava": "^3.12.1",
-    "nyc": "^15.1.0"
+    "ava": "^3.12.1"
   },
   "dependencies": {
     "@agoric/eventual-send": "^0.13.14",

packages/cosmic-swingset/package.json

@@ -13,7 +13,6 @@
   "scripts": {
     "build": "exit 0",
     "test": "ava",
-    "test:nyc": "nyc ava",
     "test:xs": "exit 0",
     "pretty-fix": "prettier --write '**/*.js'",
     "pretty-check": "prettier --check '**/*.js'",
@@ -46,8 +45,7 @@
     "esm": "^3.2.25"
   },
   "devDependencies": {
-    "ava": "^3.12.1",
-    "nyc": "^15.1.0"
+    "ava": "^3.12.1"
   },
   "eslintConfig": {
     "extends": [

packages/deploy-script-support/package.json

@@ -12,7 +12,6 @@
   "scripts": {
     "build": "exit 0",
     "test": "ava",
-    "test:nyc": "nyc ava",
     "test:xs": "exit 0",
     "pretty-fix": "prettier --write '**/*.js'",
     "pretty-check": "prettier --check '**/*.js'",
@@ -58,8 +57,7 @@
     "@agoric/install-ses": "^0.5.13",
     "@agoric/swingset-vat": "^0.17.2",
     "ava": "^3.12.1",
-    "esm": "^3.2.25",
-    "nyc": "^15.1.0"
+    "esm": "^3.2.25"
   },
   "files": [
     "src",