Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: 291 - llm_tracker is not an attribute in client class #320

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

andkoma
Copy link
Contributor

@andkoma andkoma commented Jul 27, 2024

📘 Description
initialize the llm_tracker in class client with None

🔄 Related Issue (if applicable)
#291

🎯 Goal
fix the bug, that the client class has in some cases no attribute for llm_tracker.

🔍 Additional Context
Looks like the class init is not complete processed and the attribute did not been created in some circumstances?

🧪 Testing
Fix in local environment, re-run the crewai application with agentops in two modes.
a) enabled
b) disabled.

initialize the llm_tracker with None.
bugfix: 'Client' object has no attribute 'llm_tracker' - #291
@areibman areibman requested a review from bboynton97 July 29, 2024 06:32
@areibman
Copy link
Contributor

Thanks for this! @bboynton97 what do you think?

@bboynton97
Copy link
Contributor

Thank you for the contribution @andkoma! I think there's an underlying issue here we need to investigate, but this does prevent the case for an exception halting the execution of an agent due to AgentOps.

@areibman I say we merge this and investigate the issue after

@bboynton97
Copy link
Contributor

bboynton97 commented Jul 29, 2024

@andkoma Could you merge upstream and run black .

If you dont have Black installed, run:

pip install black 'black[jupyter]'

@andkoma
Copy link
Contributor Author

andkoma commented Jul 29, 2024 via email

@bboynton97
Copy link
Contributor

There's no merge conflict. Your branch is behind and not formatted properly

@bboynton97 bboynton97 merged commit 4dc0382 into AgentOps-AI:main Jul 29, 2024
8 of 10 checks passed
@andkoma
Copy link
Contributor Author

andkoma commented Jul 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants