-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: 291 - llm_tracker is not an attribute in client class #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialize the llm_tracker with None.
bugfix: 'Client' object has no attribute 'llm_tracker' - #291
Thanks for this! @bboynton97 what do you think? |
@andkoma Could you merge upstream and run If you dont have Black installed, run:
|
Ok.
My change was just the insert of a single line statement.
This could not be the root cause for the merge result.
Regards
… Am 29.07.2024 um 21:51 schrieb Braelyn Boynton ***@***.***>:
@andkoma <https://github.com/andkoma> Could you merge upstream and run black .
If you dont have Black installed, run:
pip install black
pip install black[jupyter]
—
Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYFEB24LDSAGC7YGQCND3LZO2MK5AVCNFSM6AAAAABLRYN7NKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWG43TIMRYGY>.
You are receiving this because you were mentioned.
|
There's no merge conflict. Your branch is behind and not formatted properly |
bboynton97
approved these changes
Jul 29, 2024
I just checked this behavior,
I’ve made the change inside the web interface of the forked repo.
Maybe in this case the embedded editor destroys your expected formatting.
I will drop the fork and create a fresh one.
Regards and sorry for any circumstances
Andrew
… Am 29.07.2024 um 23:31 schrieb Braelyn Boynton ***@***.***>:
Merged #320 <#320> into main.
—
Reply to this email directly, view it on GitHub <#320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYFEBZPNUAHBQJQDQOMKIDZO2YB5AVCNFSM6AAAAABLRYN7NKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGY4DMOJRHE2TSOA>.
You are receiving this because you were mentioned.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📘 Description
initialize the llm_tracker in class client with None
🔄 Related Issue (if applicable)
#291
🎯 Goal
fix the bug, that the client class has in some cases no attribute for llm_tracker.
🔍 Additional Context
Looks like the class init is not complete processed and the attribute did not been created in some circumstances?
🧪 Testing
Fix in local environment, re-run the crewai application with agentops in two modes.
a) enabled
b) disabled.