Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tach to define module boundaries #295

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

emdoyle
Copy link
Contributor

@emdoyle emdoyle commented Jul 10, 2024

📥 Pull Request

📘 Description
This PR introduces Tach to maintain clean module boundaries. It is added as an optional dev dependency and as a CI check in GitHub Actions.

🎯 Goal
Particularly for new contributors, it is helpful to have an automatic check to validate that new changes do not violate the intended architecture of the project. Tach also serves as documentation of the logical flow of the project through tach.yml and tach show
image

🔍 Additional Context
https://docs.gauge.sh

If changes are made which introduce new cross-module dependencies, they will cause tach check to fail and point out the offending imports. If they represent an intentional design change, they can be acknowledged with tach sync.

🧪 Testing
Running tach check passes with this configuration.

@areibman areibman merged commit 801ac7d into AgentOps-AI:main Jul 17, 2024
9 of 10 checks passed
@areibman
Copy link
Contributor

Thanks @emdoyle !!

@emdoyle emdoyle deleted the tach-impl branch July 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants