Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple sessions and client #248

Merged
merged 48 commits into from
Jul 10, 2024
Merged

decouple sessions and client #248

merged 48 commits into from
Jul 10, 2024

Conversation

bboynton97
Copy link
Contributor

@bboynton97 bboynton97 commented Jun 11, 2024

Enables a single client to have multiple concurrent sessions.
Adds support for REST servers.

Copy link

gitguardian bot commented Jun 11, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12083425 Triggered Generic High Entropy Secret 04d73da tests/core_manual_tests/agentchat_agentops.ipynb View secret
12083425 Triggered Generic High Entropy Secret 04d73da tests/core_manual_tests/agentchat_agentops.ipynb View secret
12083425 Triggered Generic High Entropy Secret 071000f tests/core_manual_tests/agentchat_agentops.ipynb View secret
12083425 Triggered Generic High Entropy Secret 071000f tests/core_manual_tests/agentchat_agentops.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 65.35948% with 106 lines in your changes missing coverage. Please review.

Flag Coverage Δ
unittests 45.48% <65.35%> (+2.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agentops/__init__.py 82.25% <100.00%> (+2.94%) ⬆️
agentops/config.py 82.69% <100.00%> (+7.69%) ⬆️
agentops/decorators.py 100.00% <100.00%> (ø)
agentops/exceptions.py 100.00% <100.00%> (ø)
agentops/helpers.py 73.46% <100.00%> (+3.35%) ⬆️
agentops/meta_client.py 93.75% <ø> (+37.50%) ⬆️
agentops/agent.py 20.68% <0.00%> (-2.39%) ⬇️
agentops/client.py 66.25% <76.47%> (+11.38%) ⬆️
agentops/session.py 71.94% <69.60%> (-23.52%) ⬇️
agentops/llm_tracker.py 9.65% <11.76%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

@bboynton97 bboynton97 marked this pull request as ready for review July 1, 2024 20:38
Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

agentops/__init__.py Outdated Show resolved Hide resolved
agentops/__init__.py Outdated Show resolved Hide resolved
agentops/session.py Outdated Show resolved Hide resolved
agentops/session.py Outdated Show resolved Hide resolved
agentops/helpers.py Outdated Show resolved Hide resolved
agentops/exceptions.py Show resolved Hide resolved
agentops/client.py Outdated Show resolved Hide resolved
agentops/__init__.py Outdated Show resolved Hide resolved
agentops/__init__.py Outdated Show resolved Hide resolved
agentops/agent.py Show resolved Hide resolved
agentops/agent.py Show resolved Hide resolved
agentops/config.py Outdated Show resolved Hide resolved
agentops/helpers.py Show resolved Hide resolved
agentops/helpers.py Show resolved Hide resolved
agentops/llm_tracker.py Outdated Show resolved Hide resolved
agentops/llm_tracker.py Outdated Show resolved Hide resolved
agentops/llm_tracker.py Show resolved Hide resolved
@bboynton97 bboynton97 enabled auto-merge (squash) July 10, 2024 01:20
@bboynton97 bboynton97 merged commit d12f5f9 into main Jul 10, 2024
9 of 10 checks passed
@bboynton97 bboynton97 deleted the multiple-sessions branch July 10, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants