Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: no more sorting in TreePicker #475

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

sonhanguyen
Copy link
Contributor

@sonhanguyen sonhanguyen commented Dec 19, 2016

@codecov-io
Copy link

codecov-io commented Dec 19, 2016

Current coverage is 100% (diff: 100%)

Merging #475 into master will not change coverage

@@           master   #475   diff @@
====================================
  Files          26     26          
  Lines         407    406     -1   
  Methods        64     64          
  Messages        0      0          
  Branches       74     74          
====================================
- Hits          407    406     -1   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 60ad834...c2b0b12

Copy link
Contributor

@mdotwills mdotwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you open a direct-web PR with this adslot-ui SHA?

@mdotwills
Copy link
Contributor

@sonhanguyen sonhanguyen force-pushed the treepicker-no-sorting-by-default branch from 8e3a1a2 to c2b0b12 Compare December 20, 2016 05:19
@mdotwills
Copy link
Contributor

@omgaz need to manually test the sorting in direct-web with this commit and then we can merge.

@omgaz omgaz merged commit 6dceee0 into master Dec 21, 2016
@omgaz omgaz deleted the treepicker-no-sorting-by-default branch December 21, 2016 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants