Breaking: Fix inline Datepicker #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input elements should not be `inline` by default, inline is an opinionated view that breaks the bootstrap grid system. - Make the input container block, and use Bootstraps grid system for constraining floats and positioning as per guideline. - Add a pointer cursor and placeholder to the input for improved experience.
Current coverage is 100%@@ master #223 diff @@
==========================================
Files 23 23
Lines 474 474
Methods 82 82
Messages 0 0
Branches 68 68
==========================================
Hits 474 474
Misses 0 0
Partials 0 0
|
|
LGTM 👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input elements should not be
inlineby default, inline is an opinionated view that breaks the bootstrap grid system.