This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Modify cloneNode to handle shadow dom. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmun
reviewed
Apr 18, 2022
packages/dom/src/wc-clone.js
Outdated
| }; | ||
|
|
||
| const customOuterHTML = docElement => { | ||
| return `<html class="hydrated">${docElement.getInnerHTML()}</html>`; |
There was a problem hiding this comment.
The general approach would be to copy the attributes on the root element over instead of hard coding class="hydrated" (which a Stencil-specific thing)
mmun
reviewed
Apr 18, 2022
packages/dom/src/wc-clone.js
Outdated
Comment on lines
54
to
55
| clonedDocumentElementFragment.head = document.createDocumentFragment(); | ||
| clonedDocumentElementFragment.documentElement = clonedDocumentElementFragment.firstChild; |
There was a problem hiding this comment.
This code is pretty hacky. We should rewrite the logic here to avoid adding properties onto a fragment which don't exist.
mmun
reviewed
Apr 22, 2022
| const getOuterHTML = docElement => { | ||
| let innerHTML = docElement.getInnerHTML(); | ||
| docElement.textContent = ''; | ||
| return docElement.outerHTML.replace('</html>', `${innerHTML}</html>`); |
addepar-davidlin
approved these changes
Apr 22, 2022
c69-addepar
reviewed
Apr 25, 2022
| * This enables us to capture shadow DOM in snapshots. It takes advantage of `attachShadow`'s mode option set to open | ||
| * https://developer.mozilla.org/en-US/docs/Web/API/Element/attachShadow#parameters | ||
| */ | ||
| const deepClone = host => { |
There was a problem hiding this comment.
how do we know this (not-trivial) walker works ?
do we need any tests ? or is this code copy-pasted from somewhere ?
There was a problem hiding this comment.
It's copied from https://stackoverflow.com/a/55540552 and modified a bit. I don't think this fork is really set up to run tests.
I'd like to see the code tidied up and tested but yeah...
c69-addepar
reviewed
Apr 25, 2022
c69-addepar
approved these changes
Apr 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Percy does not provide support for capturing shadow dom as outlined in this issue: percy#280
@mmun previously did some exploration and created a working modification to Percy's cloning behavior that enables capturing shadow dom in Chrome. This PR contains the modification necessary to allow shadow dom to be properly cloned.