Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand styling capabilities to not assume :host container #184

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

bheston
Copy link
Member

@bheston bheston commented Mar 21, 2024

Pull Request

Description

Much of the styling generation logic assumes the styles are in the context of a custom element. The Adaptive UI styling generation also works really well for other component frameworks and plain html if unique class names are used.

This PR removes the assumption that the containing element is :host and better enables other scenarios.

Issues

Related to #83

Reviewer Notes

Renamed a few occurrences of host to context. I was specifically avoiding words with meaning in css like root, host, and scope.

Test Plan

Tested in Storybook

Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation for this project.

@bheston bheston self-assigned this Mar 21, 2024
@bheston bheston merged commit c4e580a into main Mar 22, 2024
3 checks passed
@bheston bheston deleted the users/bheston/adaptive-ui-expand-selectors branch March 22, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant