Skip to content

Platform to submit RFCs for the Ada & SPARK languages

Notifications You must be signed in to change notification settings

AdaCore/ada-spark-rfcs

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Project

This platform is a hub through which evolutions of the SPARK & Ada languages will be discussed, as implemented in AdaCore’s GNAT toolchain.

The aims of this platform are:

  • To give visibility on the design process of new features through a modern platform where users can give feedback on the desirability of a feature.

  • To give an opportunity to people to propose new features/improvements and fixes where they can have a direct connection with AdaCore’s language design team.

This platform is centered around language changes rather than toolchain improvements.

It is recommended to refer to the following resources for the current definition of Ada and SPARK languages:

There is no guarantee that changes discussed and eventually prototyped & implemented will ever make it into the Ada standard, even though AdaCore will do its best to collaborate with the Ada Rapporteur Group (ARG).

AdaCore will commit to discuss changes that it plans on this platform, so that users can give and get feedback on RFCs. It will also make it possible for people from the community to propose and discuss potential features and improvements.

Organisation

RFCs are submitted to review as pull request. There are two kind of RFCs:

  • High-level RFCs: Those RFCs concern a high level area where we want to make changes, and how. They should include at least two regular RFCs.

  • Regular RFCs: Those RFCs explain how a single change to the language will be made. They might (or might not) be part of a high level RFC.

Once a RFC is reviewed, it will be either abandoned or merged. When it's merged, high-level RFCs will go in the meta folder, and regular ones will first go in considered, and then, eventually, when prototyped in GNAT, in the prototyped folder.

The process

Before creating an RFC

Creating an issue

All features ideas that are not very close to a finished state should go through an issue first. It is expected that, in most cases, features ideas should go through an issue first, so that we can assess the interest there is around it.

It follows that, in 99% of the cases, and when in doubt, you should start by creating an issue rather than a RFC. There are existing issue templates to help you in the process.

If you really think you should create a RFC

Any language change can have potentially large effects on other parts of the language. There are several questions that need to be discussed for any new feature:

  • What problem does the proposed change address?

  • Is it a desirable change or not?

  • How does it interact with other features?

  • Does it fit the general philosophy of the language?

It follows that a possible first step before creating an RFC is to create an issue to informally discuss the feature, and gather different levels of feedback. The less certain you are about the feature, both in terms of desirability and in terms of maturity, the more this step should be favored.

Creating an RFC

The process to add a feature to the language starts by submitting an RFC into the RFC repository as a RST file. At that point the RFC is considered alive. It does not necessarily mean that it will get implemented, but that it is amongst those that are considered for addition.

Here is the process to get an RFC into alive state:

  • Browse the file rfc-template.md

  • Edit this file, using the pen next to the Raw and Blame buttons.

  • On the editing page, rename rfc-template.md to something descriptive such as considered/<short-feature-description>.md. Make sure to put the resulting file in the directory considered.

  • Fill in the RFC. This part of the process is the most important. RFCs that do not present convincing arguments, demonstrate impact of the design on the rest of the language, will have less chances of being considered. Don’t hesitate to get help from people sharing your mindset about a feature.

    For help on the GitHub-flavored Mardown syntax, see this quick-start guide or this more advanced guide

    If you feel like you cannot fill in large parts of the RFC template, open an issue instead.

  • Name your commit [RFC]: <name of your rfc>, and then validate the creation of the commit itself. We suggest you use a meaningful name for the branch, but this is optional.

  • On the next page, GitHub will automate the creation of the Pull Request. Just hit Create pull request.

As a pull request the RFC will receive design feedback from AdaCore’s language design team, and from the larger community, and the author should be prepared to revise it in response. Expect several iterations between discussions, consensus building, and clarifications.

At some point, a member of the AdaCore language design team will make a decision about the future of the RFC, which can be either accept, reject, or postpone.

  • A rejected RFC’s pull request will simply be closed.

  • An accepted RFC’s pull request will be merged.

  • A postponed RFC’s pull request will be labeled as "postponed".

Supporting an RFC/providing feedback

As a community member, you are encouraged to provide support/feedback on existing RFCs.

If you have remarks/comments on an RFC, you can simply comment on the RFC itself. You can sync with the RFC author to propose amendments to the RFC if you think some are necessary.

If you want simply to signal support for a proposal, you should add a +1 reaction ("thumb up") to the corresponding Pull Request's original message.

What happens afterwards

  • After an RFC has been merged in the considered folder, it will be considered for prototyping by relevant engineers at AdaCore.

    • Note that, if as a member of the community you want to try your hand at implementing a feature in GNAT, you can propose a patch against GNAT’s FSF repository, which will then be considered for merging into AdaCore’s GNAT Pro compiler. For SPARK, AdaCore’s SPARK GitHub repository is the reference implementation.
  • When a prototype has been implemented by one means or another, the RFC will be re-considered, and a pull request moving the RFC from the considered folder to the prototyped folder. Any facts/drawbacks/additional work discovered during prototyping, as well as an evaluation of the feature will be conducted on the PR. The feature will be made available through the -gnatX flag so that people from the community can play with it and give feedback too.

  • Finally, a member of the AdaCore team will give a final decision about the RFC’s inclusion in GNAT, and potential submission to the ARG if necessary.

Credits

Most of the content of this document was inspired by the RFC process from the Rust community.

About

Platform to submit RFCs for the Ada & SPARK languages

Resources

Code of conduct

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published