feat: add Touch Target Minimum section to Links and Button pages #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EmmaDawsonDev! :) I'm done with my PR. |
EmmaDawsonDev
requested changes
Jan 14, 2024
data/pageNavigationLists.ts
Outdated
| @@ -41,6 +41,7 @@ export const linkPageNavigation: IPageNavigationItem[] = [ | |||
| { linkName: "Link State and Style", href: "#linkStates" }, | |||
| { linkName: "Image and Icon Links", href: "#linkImage" }, | |||
| { linkName: "WCAG Criteria", href: "#WCAGCriteria" }, | |||
| { linkName: "Touch Target Minimum", href: "#touchTargetMinimum" }, | |||
There was a problem hiding this comment.
Please add the link object in the correct place in the list corresponding to where it appears on the page.
Please also add it to the buttonPageNavigation array.
Co-authored-by: Emma Dawson <emma.l.dawson@gmail.com>
There's already a link to WCAG at the bottom of the page
…com/CBID2/AccessibleWebDev into adding-small-section-about-WCAG-2.2
4 tasks
|
Hi @EmmaDawsonDev! :) Too many issues occured in the revision of this PR, so I closed it. The improved version in is PR #391. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a Touch Target Minimum section to the Links and Buttons pages, helping developers gain a better understanding of how to make these components more accessible.
Screenshots - If Any (Optional)
Link to issue
Closes #386
Checklist before requesting a review
and it shows no errors.
Additional Information (Optional)
It is still a work in progress.