-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Touch Target Minimum section to Links and Button pages #390
feat: add Touch Target Minimum section to Links and Button pages #390
Conversation
Hi @EmmaDawsonDev! :) I'm done with my PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chrissy. I left a few comments. Let me know if you need help with anything.
data/pageNavigationLists.ts
Outdated
@@ -41,6 +41,7 @@ export const linkPageNavigation: IPageNavigationItem[] = [ | |||
{ linkName: "Link State and Style", href: "#linkStates" }, | |||
{ linkName: "Image and Icon Links", href: "#linkImage" }, | |||
{ linkName: "WCAG Criteria", href: "#WCAGCriteria" }, | |||
{ linkName: "Touch Target Minimum", href: "#touchTargetMinimum" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the link object in the correct place in the list corresponding to where it appears on the page.
Please also add it to the buttonPageNavigation array.
Co-authored-by: Emma Dawson <emma.l.dawson@gmail.com>
There's already a link to WCAG at the bottom of the page
…com/CBID2/AccessibleWebDev into adding-small-section-about-WCAG-2.2
Hi @EmmaDawsonDev! :) Too many issues occured in the revision of this PR, so I closed it. The improved version in is PR #391. |
Describe your changes
This PR adds a Touch Target Minimum section to the Links and Buttons pages, helping developers gain a better understanding of how to make these components more accessible.
Screenshots - If Any (Optional)
Link to issue
Closes #386
Checklist before requesting a review
and it shows no errors.
Additional Information (Optional)
It is still a work in progress.