-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added puncuation #369
added puncuation #369
Conversation
Hello @itolimaesther, thanks for raising a pull request in this project. The maintainers of this project are volunteers so please be understanding if it takes time before you get a response. We still appreciate your help with creating pull requests! |
@EmmaDawsonDev please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR Esther. For some reason your code formatter has formatted some of the code snippets which makes them display wrongly. Please remove the formatting so that only the punctuation change is left.
Alright. |
@EmmaDawsonDev will I need to create another PR? Though I can't see a way to do that. |
No, you should just be able to make the changes and push them and they will be reflected here. |
I have made some code changes, removed the prettier formatter, and also added content for the link. Please check and let me know if the issue persists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good so far. I've just left a few comments for minor things that need improving
Alright. I have seen all your comments. I make the corrections and I will make a push again. |
I'm going to merge this into a temporary branch and fix the issues when I get time. Thanks so much for your help so far :) |
I apologize for finishing with this. I have been down for some time. Please let me know if there are anything I need to add. |
No worries. I fully understand that life gets in the way sometimes. |
* added puncuation (#369) * added puncuation * Added link content * updated image src * Reformat button code snippets * Update descriptive link text to accessible link names * Update link state section * Update image and icons section * Edit links page * Add icon code examples * Add focus indicator paragraph --------- Co-authored-by: Esther <itolimaesther@gmail.com>
Describe your changes
I added punctuation(support,) to the sentence "An empty alt attribute has the most wide-spread support so that should be your go-to choice when using icons." for better readability.
Screenshots - If Any (Optional)
Link to issue
Closes #367
Checklist before requesting a review
and it shows no errors.
Additional Information (Optional)
Any additional information that you want to give us.