Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nav link state for screen readers #344

Merged

Conversation

SatyamSetia
Copy link
Member

Describe your changes

Added aria-current to anchor tags in NavItem component. if link is active then, set the value of aria-current to be "page" else set it to false.

Link to issue

Closes #343

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

@SatyamSetia
Copy link
Member Author

Hey, @EmmaDawsonDev
Requesting your review on this PR whenever you get time.

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for your help!

@EmmaDawsonDev EmmaDawsonDev merged commit 97e0a54 into AccessibleForAll:main Jul 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active page state not announced by screen reader nav links
2 participants