Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced nextjs Link with HTML a #305

Merged

Conversation

Neha
Copy link
Contributor

@Neha Neha commented May 27, 2023

Describe your changes

Replaced NextJS Link with HTML a to fix the onfocus issue.

Screenshots - If Any (Optional)

Link to issue

Closes #292

Checklist before requesting a review

  • I have performed a self-review of my code.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.
  • I have checked my code with an automatic accessibility tool such as Axe Dev Tools or Wave
    and it shows no errors.

Additional Information (Optional)

We should add some visual style to communicate to the user they have to jump to a specific section on the tab

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I know you mentioned the need for a visual style when using a skip link but this is not necessary in this case as we are not using the link to skip to something focusable/interactive. The next tab stop will again show the focus indicator as expected.

@EmmaDawsonDev EmmaDawsonDev merged commit 07e614f into AccessibleForAll:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: focus doesn’t move from page navigation
2 participants