Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need scroll margin or padding #365

Closed
EmmaDawsonDev opened this issue Aug 27, 2023 · 3 comments · Fixed by #366
Closed

Need scroll margin or padding #365

EmmaDawsonDev opened this issue Aug 27, 2023 · 3 comments · Fixed by #366
Assignees
@2div
Labels
bug Something isn't working CSS enhancement New feature or request good first issue Good for newcomers

Comments

@EmmaDawsonDev
Copy link
Member

Describe the bug
When a user uses the page navigation links to navigate to a section of the page the heading ends up hidden underneath the fixed header. If I remember correctly it is possible to add something like scroll-margin-top as a css property and set it to the height of the header (a css variable) in order to push the scroll position down and prevent the heading from being hidden.

To Reproduce
Steps to reproduce the behavior:

  1. Go to navigation page
  2. Click on one of the links in the page navigation accordion
  3. Notice that section heading is not visible

Expected behavior
Section heading is visible below the header
@EmmaDawsonDev EmmaDawsonDev added bug Something isn't working enhancement New feature or request good first issue Good for newcomers CSS labels Aug 27, 2023
@2div
Copy link
Contributor

2div commented Aug 27, 2023

Hello , i would like to try to work on this bug and try to fix it.

@EmmaDawsonDev
Copy link
Member Author

Sure! Have a go and just let me know if you need any help

2div pushed a commit to 2div/AccessibleWebDev that referenced this issue Aug 27, 2023
Fixed AccessibleForAll#365 i added scroll-margin-top:5rem to global.c…
0a99424 
…ss file
@2div 2div mentioned this issue Aug 27, 2023
Merged
@2div
Copy link
Contributor

2div commented Aug 29, 2023

Hi can you please my PR?

2div pushed a commit to 2div/AccessibleWebDev that referenced this issue Aug 30, 2023
Revert "Fixed AccessibleForAll#365 i added scroll-margin-top:5rem to …
02cb717 
…global.css file"

This reverts commit 0a99424.
2div pushed a commit to 2div/AccessibleWebDev that referenced this issue Aug 31, 2023
Fixed AccessibleForAll#365 i added scroll-margin-top:5rem to global.c…
7d2b71e 
…ss file
EmmaDawsonDev pushed a commit that referenced this issue Sep 3, 2023
@2div
Fixed #365 i added scroll-margin-top:5rem to global.css file (#366)
07221c9 
* Fixed #365 i added scroll-margin-top:5rem to global.css file

* Revert "Fixed #365 i added scroll-margin-top:5rem to global.css file"

This reverts commit 0a99424.

* Fixed #365 i added scroll-margin-top:5rem to global.css file

---------

Co-authored-by: 2div <mhersi819@gamil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2div 2div

Labels
bug Something isn't working CSS enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #365 i added scroll-margin-top:5rem to global.css file 2div/AccessibleWebDev
2 participants
@EmmaDawsonDev @2div