Properly expose header files for float exceptions #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After moving to Iex, properly expose header files so people can actually use the floating point exception handling code. Further, hide symbols that should be internal to the library Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
lgritz
reviewed
Mar 14, 2021
| @@ -42,7 +42,7 @@ int fpExceptions (); | |||
| //------------------------------------------ | |||
|
|
|||
| extern "C" typedef void (* FpExceptionHandler) (int type, const char explanation[]); | |||
There was a problem hiding this comment.
Does extern "C" mean anything for a typedef?
There was a problem hiding this comment.
I had the same question. It was there, so I just left it, although I don't believe so, but I wasn't sure if it implied "nothrow" when in a C++ context, but is still a C function in a portable fashion?
cary-ilm
added
Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to Iex, properly expose header files so people can actually
use the floating point exception handling code.
Further, hide symbols that should be internal to the library
Signed-off-by: Kimball Thurston kdt3rd@gmail.com