better flag/type verification in deep input files #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve validation checks when using DeepTiledInputFile and DeepScanlineInputFile. DeepTiledInputFile wasn't verifying
typeattribute correctly on multipart files. Also DeepTiledInputFile and DeepScanlineInputFile were only checking thetypeattribute, and not confirming the version flags were consistent. If there's an inconsistency between thetypeattribute and the version flags, the version flags should be assumed to be correct.Addresses:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31539
This file has no deep ('nonImage') or tiled flags set, but has a type attribute set to 'deeptiled', which is inconsistent. MultipartInputFile was treating the file as a scanline image, but DeepTiled was treating this as a deep tiled image. This meant exrcheck's test for large tiles were being bypassed.
Signed-off-by: Peter Hillman peterh@wetafx.co.nz