Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to "IlmBase" #929

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

cary-ilm
Copy link
Member

The term "IlmBase" and "ILMBASE" are relics of the earlier project organization and should be completely eliminated. The Iex and IlmThread libraryes are now simply sub-libraries of the OpenEXR project, and there's no attempt to package or version them for independent distribution.

This change includes:

  • No more IlmBase.pc
  • IlmBaseConfig.h is split into IexConfig.h and IlmThreadConfig.h
  • Renames the macro symbolse ILMBASE_ to either IEX_ or ILMTHREAD_

Signed-off-by: Cary Phillips cary@ilm.com

The term "IlmBase" and "ILMBASE" are relics of the earlier project
organization and should be completely eliminated. The Iex and
IlmThread libraryes are now simply sub-libraries of the OpenEXR
project, and there's no attempt to package or version them for
independent distribution.

This change includes:

* No more IlmBase.pc
* IlmBaseConfig.h is split into IexConfig.h and IlmThreadConfig.h
* Renames the macro symbolse ILMBASE_<name> to either IEX_<name> or ILMTHREAD_<name>

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can tell everything is covered. I double checked all the cmake mods, looks good.

@cary-ilm cary-ilm merged commit 734f962 into AcademySoftwareFoundation:master Feb 24, 2021
@cary-ilm cary-ilm added Build A problem with building or installing the library. Documentation Developer guide, web site, project policies, etc. v3.0.0-beta labels Mar 21, 2021
@cary-ilm cary-ilm deleted the pkg-config-fix branch May 18, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build A problem with building or installing the library. Documentation Developer guide, web site, project policies, etc. v3.0.0-beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants