exrcheck: Revert to using 'getStep' for Rgba interfaces #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31044
Before #902,
Imf::checkOpenEXRFile's reduceTime mode would skip scanlines on images with a large number of pixels or scanlines. Instead, the 'reduceTime' flag would cause a test to fail immediately it encountered a read error. This means small files on disk generally fail quickly to prevent the tests taking too long to run.In this case, the source file is very large but has no R,G,B or A channels, so the RgbaFile interfaces do not read any data from the file. This means no read errors are encountered by RgbaFile, so the entire file is read, which takes several minutes.
This PR restores the skipping behavior but only for RgbaInputFile API.
Signed-off-by: Peter Hillman peterh@wetafx.co.nz