Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy throw() specifications, conform to c++11 #864

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Remove legacy throw() specifications, conform to c++11 #864

merged 2 commits into from
Nov 19, 2020

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Nov 13, 2020

Several of them were wrong anyway, as the functions were allocating
strings.

Signed-off-by: Kimball Thurston kdt3rd@gmail.com

@kdt3rd
Remove legacy throw() specifications, conform to c++11
ee03cc2 
Several of them were wrong anyway, as the functions were allocating
strings.

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
meshula approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It's gruesome that's there's no noexcept std::string; we have an exception reporting class that can itself except 😭

cary-ilm
cary-ilm approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 95d2376 into AcademySoftwareFoundation:master Nov 19, 2020
@kdt3rd kdt3rd deleted the clean_exception_spec branch February 12, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshula meshula meshula approved these changes

@cary-ilm cary-ilm cary-ilm approved these changes

Assignees
No one assigned
Labels
v3.0.0-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdt3rd @meshula @cary-ilm