Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress clang undefined behavior sanitizer in DeepImageStateAttribute::copyValuesFrom() #794

Merged

Conversation

cary-ilm
Copy link
Member

A better solution to handling of undefined DeepImageState enums than #779, this restricts the suppression specifically to the handling of this particular attribute. For this attribute, it is permissible for the value to be an invalid enum value.

Addresses https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23996

Signed-off-by: Cary Phillips cary@ilm.com

…e::copyValuesFrom()

Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@peterhillman peterhillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though presumably we will have to revisit this if/when other compilers support the undefined behavior sanitizer.

@cary-ilm cary-ilm merged commit 69450d1 into AcademySoftwareFoundation:master Jul 27, 2020
@cary-ilm cary-ilm deleted the deepimagestateattribute branch May 18, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants