Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPENEXR_PACKAGE_NAME #755

Merged

Conversation

cary-ilm
Copy link
Member

This seems to have been a copy/paste error.

Signed-off-by: Cary Phillips cary@ilm.com

Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Cary. I got jammed up and just didn't have the time yet to find the source of the problem myself.

@lgritz
Copy link
Contributor

lgritz commented Jun 11, 2020

Closes #754

@cary-ilm cary-ilm merged commit dfcfed7 into AcademySoftwareFoundation:master Jun 11, 2020
@cary-ilm cary-ilm added this to the v2.5.2 milestone Jun 11, 2020
This was referenced Jun 11, 2020
@cary-ilm cary-ilm changed the title Fix OPENXR_PACKAGE_NAME Fix OPENEXR_PACKAGE_NAME Jun 13, 2020
@cary-ilm
Copy link
Member Author

@lgritz, should we patch this into v2.4.2 as well?

@lgritz
Copy link
Contributor

lgritz commented Jun 14, 2020

If we're cutting a 2.4 release anyway, yes, it's such an easy fix.

@lgritz
Copy link
Contributor

lgritz commented Jun 14, 2020

It was 100% wrong before, so there is literally no risk of breaking any relied-upon behavior with the fix.

cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Jun 14, 2020
Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm added a commit that referenced this pull request Jun 14, 2020
Signed-off-by: Cary Phillips <cary@ilm.com>
smartin-13 pushed a commit to smartin-13/openexr that referenced this pull request Jul 23, 2020
Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: smartin-13 <61707536+smartin-13@users.noreply.github.com>
smartin-13 added a commit to smartin-13/openexr that referenced this pull request Jul 24, 2020
cary-ilm added a commit that referenced this pull request Aug 9, 2020
Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm deleted the openexr-package-fix branch May 18, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants